Log a warning that file-configs override service-discovery configs #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do Agent 6 or 7 allow checks defined in multiple sources per my use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Logs a warning if a service-discovery configured check will be ignored if the same-named check was already configured from a file.
Motivation
I have an haproxy.yaml file pointing at one instance of haproxy that I want to monitor on all servers. I am using Docker service discovery to configure other containers for service checks. This week I wanted to deploy a new use case for an haproxy container, and so I diligently added the Docker labels for an haproxy check. Nothing happened. Radio silence in the logs files.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
A better fix would be to merge the
instanceslist from the file with the service discovered-instances list. Ironically, there is code in the service discovery config module to do exactly this, and then it is dutifully discarded if a file config exists. But first I want to solve the head-banging-on-wall problem of failing to log the discarded config.