Adding container_name tag and ability to specify docker labels as tag…

…s in service discovery
DataDog · Mar 24, 2017 · f51af49 · f51af49
1 parent 1445662
commit f51af49
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 9 deletions.
diff --git a/tests/core/test_service_discovery.py b/tests/core/test_service_discovery.py
@@ -115,13 +115,13 @@ class TestServiceDiscovery(unittest.TestCase):
         # image_name: ([(source, (check_name, init_tpl, instance_tpl, variables))], (expected_config_template))
         'image_0': (
             [('template', ('check_0', {}, {'host': '%%host%%'}, ['host']))],
-            ('template', ('check_0', {}, {'host': '127.0.0.1'}))),
+            ('template', ('check_0', {}, {'host': '127.0.0.1', 'tags': ['container_name:69ff25598b23']}))),
         'image_1': (
             [('template', ('check_1', {}, {'port': '%%port%%'}, ['port']))],
-            ('template', ('check_1', {}, {'port': '1337'}))),
+            ('template', ('check_1', {}, {'port': '1337', 'tags': ['container_name:69ff25598b23']}))),
         'image_2': (
             [('template', ('check_2', {}, {'host': '%%host%%', 'port': '%%port%%'}, ['host', 'port']))],
-            ('template', ('check_2', {}, {'host': '127.0.0.1', 'port': '1337'}))),
+            ('template', ('check_2', {}, {'host': '127.0.0.1', 'port': '1337', 'tags': ['container_name:69ff25598b23']}))),
     }
 
     # raw templates coming straight from the config store

diff --git a/utils/service_discovery/sd_docker_backend.py b/utils/service_discovery/sd_docker_backend.py
@@ -17,6 +17,7 @@
 from utils.service_discovery.config_stores import get_config_store
 
 DATADOG_ID = 'com.datadoghq.sd.check.id'
+DEFAULT_COLLECT_LABELS_AS_TAGS = ""
 
 log = logging.getLogger(__name__)
 
@@ -73,6 +74,7 @@ class SDDockerBackend(AbstractSDBackend):
 
     def __init__(self, agentConfig):
         try:
+            self.collect_labels_as_tags = agentConfig.get('sd_docker_collect_labels_as_tags', DEFAULT_COLLECT_LABELS_AS_TAGS).split(",")
             self.config_store = get_config_store(agentConfig=agentConfig)
         except Exception as e:
             log.error('Failed to instantiate the config store client. '
@@ -245,6 +247,26 @@ def _extract_port_from_list(self, ports, tpl_var):
     def get_tags(self, state, c_id):
         """Extract useful tags from docker or platform APIs. These are collected by default."""
         tags = []
+
+        container = state.inspect_container(c_id)
+
+        # Get some standard tags, like container name
+        container_name = DockerUtil.container_name_extractor(container)[0]
+        tags.append("%s:%s" % ("container_name", container_name))
+
+        # Collect any specified docker labels as tags
+        c_labels = container.get('Config', {}).get('Labels', {})
+        for k in self.collect_labels_as_tags:
+            if k in c_labels.keys():
+                v = c_labels[k]
+                if k == SWARM_SVC_LABEL and Platform.is_swarm():
+                    if v:
+                        tags.append("swarm_service:%s" % v)
+                elif not v:
+                    tags.append(k)
+                else:
+                    tags.append("%s:%s" % (k,v))
+
         if Platform.is_k8s():
             pod_metadata = state.get_kube_config(c_id, 'metadata')
 
@@ -284,12 +306,6 @@ def get_tags(self, state, c_id):
             # For deployment we only need to do it if the pod creator is a ReplicaSet.
             # Details: https://kubernetes.io/docs/user-guide/deployments/#selector
 
-        elif Platform.is_swarm():
-            c_labels = state.inspect_container(c_id).get('Config', {}).get('Labels', {})
-            swarm_svc = c_labels.get(SWARM_SVC_LABEL)
-            if swarm_svc:
-                tags.append('swarm_service:%s' % swarm_svc)
-
         return tags
 
     def _get_additional_tags(self, state, c_id, *args):