Add Cardinality common field #883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdhif
changed the title
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
4 times, most recently
from
4f4fc36 to
a31858a
Compare
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
2 times, most recently
from
39739aa to
561c672
Compare
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
20 times, most recently
from
9bfa236 to
25d7aec
Compare
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
from
25d7aec to
648d06d
Compare
| @@ -1343,6 +1380,8 @@ def event( | |||
| string = "%s|#%s" % (string, ",".join(tags)) | |||
| if self._container_id: | |||
| string = "%s|c:%s" % (string, self._container_id) | |||
| if cardinality: | |||
| string = "%s|card:%s" % (string, cardinality) | |||
There was a problem hiding this comment.
🔴 Code Vulnerability
potential SQL injection (...read more)
Check for declarations of variables for a SQL statement where we have potential SQL injections.
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
from
648d06d to
76181c4
Compare
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
5 times, most recently
from
d3b3d72 to
324c61b
Compare
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
from
324c61b to
34e626f
Compare
|
What happens when this is used with an Agent version that doesn't have support for the structured |
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
from
34e626f to
d8b986e
Compare
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
from
d8b986e to
09092f1
Compare
Hey @tobz 👋 The Agent will simply discard the unknown common field and the Agent cardinality ( |
Signed-off-by: Wassim DHIF <[email protected]>
wdhif
force-pushed
the
CONTP-582/wassim.dhif/implement-cardinality-common-field
branch
from
09092f1 to
99bdf37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement the
card:common field to DogStatsD Datagram spec. This new field is used to override the Agent cardinality.Description of the Change
Adds a new cardinality setting that can be either:
This settings is then send as the
card:common field.Alternate Designs
Possible Drawbacks
None
Verification Process
Unit tests have been implemented to test the feature. QA has been done manually and can be found in DataDog/datadog-agent#32917.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.