Make it possible to post related events #786
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
dogshell
interprets--related_event_id
as a string, not an integer, which means the backend refuses to work with it. The fix is simple; to tell argparse that it's an int.Requirements for Contributing to this repository
What does this PR do?
Fix #785 by adding typing to related event IDs in argparse.
Description of the Change
To ensure that the JSON API is sent an integer and not a string, we add
type=int
to the relevant argparse declaration.Alternate Designs
You could do it at the call site, or otherwise parse it, but argparse makes this relatively easy.
Possible Drawbacks
If you were in the habit of posting random garbage to related event ID and expecting it to fail, it will now fail slightly earlier.
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.