support nested DD_API_KEY secret in lambda forwarder #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please run |
ge0Aja
reviewed
Sep 30, 2024
ge0Aja
reviewed
Oct 1, 2024
ge0Aja
reviewed
Oct 1, 2024
aws/logs_monitoring/settings.py
Outdated
| "Successfully retrieved the Datadog API key from 'DD_API_KEY'." | ||
| ) | ||
| else: | ||
| raise ValueError("The secret does not contain the 'DD_API_KEY' field.") |
There was a problem hiding this comment.
Just noticed raising a ValueError here is not properly handled down stream and will lead to an uncaught exception.
I suggest to handle it or simply log an error as we'd still have the DD_API_KEY set to the default value <YOUR_DATADOG_API_KEY> which won't work anw
There was a problem hiding this comment.
Whoops, sorry for the delay. Sounds good, updating.
There was a problem hiding this comment.
Updated, lmk if that looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for nested
DD_API_KEYin AWS SecretsManager.Motivation
It is common for organizations and individuals to store this in a shared dictionary with other secrets in AWS, which is not currently supported.
Testing Guidelines
Additional Notes
Types of changes
Check all that apply