Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWSMC-588] Support Bedrock log source #708

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

ktmq
Copy link
Contributor

@ktmq ktmq commented Nov 13, 2023

What does this PR do?

Enables setting bedrock as the source tag for logs coming from s3 or Cloudwatch log groups

Motivation

Testing Guidelines

Tested by building the layer and using with a deployed Forwarder Lambda, configuring Model Invocation logs for both S3 and CloudWatch for Bedrock in the AWS account, and running some test model invocations to produce logs. Verified that both S3 and CloudWatch logs were received in the org with the source and service tags correctly set to bedrock.
image

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Nov 13, 2023
@ktmq ktmq marked this pull request as ready for review November 14, 2023 19:53
@ktmq ktmq merged commit c372bd3 into master Nov 16, 2023
12 checks passed
@ktmq ktmq deleted the katie.mckew/awsmc-588-add-bedrock-logs-parser branch November 16, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants