Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor E2E tests #1577

Merged
merged 22 commits into from
Jan 31, 2025
Merged

Refactor E2E tests #1577

merged 22 commits into from
Jan 31, 2025

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented Dec 17, 2024

What does this PR do?

  • Add new kind E2E provisioner that leverages the NewOperator and NewDDAWithOperator methods from test-infra-definitions to create either a local kind cluster or AWS-hosted kind cluster
  • Refactor generic k8s E2E tests into its own test suite
  • Enable fakeintake in the new kind E2E provisioner

Motivation

Improve E2E usability and reliability

Additional Notes

Requires these changes from the datadog-agent/test/new-e2e module:

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

test/e2e/tests/k8sSuite/k8sSuite_test.go Outdated Show resolved Hide resolved
test/e2e/go.mod Outdated Show resolved Hide resolved
@fanny-jiang fanny-jiang requested a review from a team as a code owner December 17, 2024 23:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.14%. Comparing base (7f198ad) to head (dda63e8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1577   +/-   ##
=======================================
  Coverage   49.14%   49.14%           
=======================================
  Files         218      218           
  Lines       21017    21017           
=======================================
  Hits        10328    10328           
  Misses      10148    10148           
  Partials      541      541           
Flag Coverage Δ
unittests 49.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f198ad...dda63e8. Read the comment docs.

go.mod Outdated Show resolved Hide resolved
test/e2e/go.mod Outdated Show resolved Hide resolved
fanny-jiang and others added 9 commits January 3, 2025 10:23
* bump go deps and small fixes

* add new kind provisioners (aws and local) and update generic k8s e2e tests

* rename files, use new-e2e dev module

* sync go version

* update licenses

* allow golang version failure

* fix stack name

* fixes for CI

* Update bundle and manager config from v1.11 (#1599)

* fix flakes

* fix flakes

---------

Co-authored-by: Timothée Bavelier <[email protected]>
* make command for a specific e2e test

* update command to use env var

* updated e2e specific test

* remove parentheses from test headers

* update e2e-tests

* nit
* comment lots of stuff to simplify dev

* apm e2e test and un-comment for dev

* rebase on latest fanny

* apm e2e test refactor

* fix apm refactor

* remove pre-refactor apm test

* remove apm pre refactor util func

* remove nginx cleanup since it's for pre refactor test

* fix apm e2e refactor: avoid race + remove socket from volume def

* verify k8s version before checking local service traces

---------

Co-authored-by: Fanny Jiang <[email protected]>
# Conflicts:
#	go.mod
#	go.sum
#	go.work
#	go.work.sum
#	test/e2e/go.mod
#	test/e2e/go.sum
* Bump datadog-agent dependencies

* update-golang

* licenses, go.mod

* update-golang

* run update-golang in build

* build fixes after update, bump golang to 1.23.5

* build fix

* update ddrestiry golang url

* fix e2e go.mod

* fix eds ambiguous version

* update-golang

* fix licenses

---------

Co-authored-by: Fanny Jiang <[email protected]>
Copy link
Contributor

@levan-m levan-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor, it better structured now! There are few nitpicks we can address in follow-up PR.

@fanny-jiang fanny-jiang merged commit 0a7ed51 into main Jan 31, 2025
24 checks passed
@fanny-jiang fanny-jiang deleted the fanny/refactor-kind-e2e branch January 31, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants