Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for sfn->Lambda context injection #1463

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Sep 18, 2024

What and why?

Updates documentation to clarify:

  • different cases and their expected behavior
  • which case each code section is addressing
  • which case each test is addressing

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@lym953 lym953 added documentation Improvements or additions to documentation serverless Related to [lambda, stepfunctions, cloud-run] labels Sep 18, 2024
@lym953 lym953 requested review from a team as code owners September 18, 2024 18:31
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 18, 2024

Datadog Report

Branch report: yiming.luo/fix-step-func-12
Commit report: 7cfa07b
Test service: datadog-ci-tests

✅ 0 Failed, 392 Passed, 0 Skipped, 1m 28.81s Total duration (2m 1.67s time saved)

Copy link
Contributor

@avedmala avedmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we don't mention StateMachine in some areas like Case 2.1 and 2.3

LGTM otherwise, thank you!

@lym953 lym953 changed the title Update documentation for xfn->Lambda context injection Update documentation for sfn->Lambda context injection Sep 18, 2024
Base automatically changed from yiming.luo/fix-step-func-11 to master September 18, 2024 19:12
@lym953 lym953 merged commit 3d3f2df into master Sep 18, 2024
18 checks passed
@lym953 lym953 deleted the yiming.luo/fix-step-func-12 branch September 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation serverless Related to [lambda, stepfunctions, cloud-run]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants