-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject context for sfn->Lambda when no Payload exists (case 1) #1460
Conversation
be61946
to
4c27c0e
Compare
Datadog ReportBranch report: ✅ 0 Failed, 376 Passed, 0 Skipped, 1m 27.44s Total duration (2m 2.41s time saved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4c27c0e
to
11aaad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should hold off on removing StateMachine
from the schema for now
11aaad6
to
f001b4f
Compare
f001b4f
to
f7222ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating!
What and why?
In Step Machine definition, if a Lambda function doesn't have
Payload
field, right now we are injecting context usingThis PR changes it to:
which passes less information.
This is case #1 in this design doc: Fixing Step Function Instrumentation
Testing
Automated testing
Pass the touched tests
Manual testing
Steps
Payload
fieldyarn prepack
./dist/cli.js stepfunctions instrument
Result
"Payload.$": "$$['Execution', 'State']"
was added to Lambda definitionReview checklist