Skip to content

Commit

Permalink
[synthetics] Fix retry attempt wording
Browse files Browse the repository at this point in the history
  • Loading branch information
Drarig29 committed Sep 13, 2024
1 parent f1f772b commit 29ba21a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ exports[`Default reporter resultEnd Retryable test - Edge case: fails, then retr
 - Assertion failed:
 ▶ responseTime should be less than 1000. Actual: 1234
[1m[31m✖[39m[22m [[1m[31mblocking[39m[22m] [[1m[2maaa-aaa-aaa[22m[22m] [1mTest name[22m - [1m[31mlocation: [1mFrankfurt (AWS)[22m[1m[39m[22m ([2mattempt 2, success[22m)
[1m[31m✖[39m[22m [[1m[31mblocking[39m[22m] [[1m[2maaa-aaa-aaa[22m[22m] [1mTest name[22m - [1m[31mlocation: [1mFrankfurt (AWS)[22m[1m[39m[22m ([2mattempt 2, done[22m)
• Total duration: 123 ms - View test run details:
⎋ https://app.datadoghq.com/synthetics/details/aaa-aaa-aaa?resultId=0&batch_id=123&from_ci=true (previous attempt)
✖ GET - http://fake.url
Expand All @@ -125,7 +125,7 @@ exports[`Default reporter resultEnd Retryable test - Usual case: passes after 1
 - Assertion failed:
 ▶ responseTime should be less than 1000. Actual: 1234
[1m[32m✓[39m[22m [[1m[2maaa-aaa-aaa[22m[22m] [1mTest name[22m - [1m[32mlocation: [1mFrankfurt (AWS)[22m[1m[39m[22m ([2mattempt 2, success[22m)
[1m[32m✓[39m[22m [[1m[2maaa-aaa-aaa[22m[22m] [1mTest name[22m - [1m[32mlocation: [1mFrankfurt (AWS)[22m[1m[39m[22m ([2mattempt 2, done[22m)
• Total duration: 123 ms - View test run details:
⎋ https://app.datadoghq.com/synthetics/details/aaa-aaa-aaa?resultId=1&batch_id=123&from_ci=true
✓ GET - http://fake.url
Expand All @@ -148,7 +148,7 @@ exports[`Default reporter resultEnd Retryable test - Usual case: passes after ma
 - Assertion failed:
 ▶ responseTime should be less than 1000. Actual: 1234
[1m[32m✓[39m[22m [[1m[2maaa-aaa-aaa[22m[22m] [1mTest name[22m - [1m[32mlocation: [1mFrankfurt (AWS)[22m[1m[39m[22m ([2mattempt 3, success[22m)
[1m[32m✓[39m[22m [[1m[2maaa-aaa-aaa[22m[22m] [1mTest name[22m - [1m[32mlocation: [1mFrankfurt (AWS)[22m[1m[39m[22m ([2mattempt 3, done[22m)
• Total duration: 123 ms - View test run details:
⎋ https://app.datadoghq.com/synthetics/details/aaa-aaa-aaa?resultId=2&batch_id=123&from_ci=true
✓ GET - http://fake.url
Expand Down
2 changes: 1 addition & 1 deletion src/commands/synthetics/reporters/default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ const getAttemptSuffix = (passed: boolean, retries: number, maxRetries: number,
return chalk.dim(`attempt ${current} of ${max}, retrying…`)
}

return chalk.dim(`attempt ${current}, success`)
return chalk.dim(`attempt ${current}, done`)
}

if (isTimedOutRetry(retries, maxRetries, timedOut)) {
Expand Down

0 comments on commit 29ba21a

Please sign in to comment.