Revert "revert static quality gates"

[Pythyu]

What does this PR do?

Fix the issue for python older than 3.12 failing the notify job

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Added Jobs

static_quality_gates

static_quality_gates:
  allow_failure: true
  image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
  needs:
  - artifacts: true
    job: agent_deb-x64-a7
  - artifacts: true
    job: docker_build_agent7
  rules:
  - if: $CI_COMMIT_BRANCH == "main"
    when: never
  - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    when: never
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - when: on_success
  script:
  - DOCKER_LOGIN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO user)
    || exit $?
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO token | crane auth
    login --username "$DOCKER_LOGIN" --password-stdin "$DOCKER_REGISTRY_URL"
  - EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
    needs gitlab runner restart"; exit $EXIT; fi
  - DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
    token)" || exit $?; export DATADOG_API_KEY
  - export DD_API_KEY="$DATADOG_API_KEY"
  - GITHUB_KEY_B64=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP key_b64)
    || exit $?; export GITHUB_KEY_B64
  - GITHUB_APP_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP app_id)
    || exit $?; export GITHUB_APP_ID
  - GITHUB_INSTALLATION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP
    installation_id) || exit $?; export GITHUB_INSTALLATION_ID
  - echo "Using agent GitHub App"
  - inv quality-gates.parse-and-trigger-gates
  stage: functional_test
  tags:
  - arch:amd64

Changes Summary

Removed	Modified	Added	Renamed
0	0	1	0

ℹ️ Diff available in the job log.

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 39498dd6a427f22701fad2afdbbcffce584e70ac

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	0.00MB	✅	871.04MB	871.04MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	873.44MB	873.44MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	861.32MB	861.32MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.09MB	59.09MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.16MB	59.16MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.16MB	59.16MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.56MB	56.56MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	445.68MB	445.68MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	86.22MB	86.22MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	86.29MB	86.29MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	86.29MB	86.29MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	82.49MB	82.49MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	82.56MB	82.56MB	0.50MB
datadog-agent-x86_64-rpm	-0.00MB	✅	883.18MB	883.18MB	0.50MB
datadog-agent-x86_64-suse	-0.00MB	✅	883.18MB	883.18MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	844.9MiB	858.45MiB	184.2MiB	214.3MiB
✅	static_quality_gate_docker_agent_amd64	929.13MiB	942.69MiB	310.7MiB	321.56MiB

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 54878632 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: dd992950-4052-4cd1-a15c-888848b6584d

Baseline: 39498dd
Comparison: 384e4b8
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.46	[-0.31, +1.23]	1	Logs
➖	file_tree	memory utilization	+0.17	[+0.10, +0.24]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.27, +0.29]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.73, +0.74]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.00	[-0.47, +0.46]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.93, +0.92]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.80, +0.76]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.03	[-0.67, +0.61]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.95, +0.87]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.04	[-0.93, +0.84]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.38	[-0.46, -0.30]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.54	[-1.41, +0.32]	1	Logs
➖	quality_gate_idle	memory utilization	-0.58	[-0.61, -0.55]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.97	[-1.04, -0.90]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.20	[-5.21, +0.82]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.