Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ecs by default #33689

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

aureleoules
Copy link
Member

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@aureleoules aureleoules requested review from a team as code owners February 4, 2025 11:29
@github-actions github-actions bot added team/container-app short review PR is simple enough to be reviewed quickly labels Feb 4, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Uncompressed package size comparison

Comparison with ancestor d6ef294c33388e2c94023d80d7fa5a4381862e09

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 873.29MB 873.29MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 883.03MB 883.03MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 883.03MB 883.03MB 0.50MB
datadog-agent-arm64-deb 0.00MB 861.18MB 861.18MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.03MB 59.03MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.11MB 59.11MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.11MB 59.11MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.52MB 56.52MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 445.51MB 445.51MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.11MB 86.11MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.18MB 86.18MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.18MB 86.18MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.38MB 82.38MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.45MB 82.45MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 870.90MB 870.90MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54857443 --os-family=ubuntu

Note: This applies to commit 41baad8

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 844.75MiB 858.45MiB 203.55MiB 214.3MiB
static_quality_gate_docker_agent_amd64 928.99MiB 942.69MiB 310.65MiB 321.56MiB

Copy link

cit-pr-commenter bot commented Feb 4, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f2c5764a-4ae5-428d-bf72-396b73688127

Baseline: d6ef294
Comparison: 41baad8
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +1.15 [+0.36, +1.95] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.24 [-0.56, +1.03] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.19 [-0.27, +0.66] 1 Logs
quality_gate_logs % cpu utilization +0.15 [-2.92, +3.22] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.08 [-0.76, +0.93] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.89, +0.96] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.67, +0.66] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.93, +0.92] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.29, +0.28] 1 Logs
quality_gate_idle_all_features memory utilization -0.14 [-0.22, -0.07] 1 Logs bounds checks dashboard
file_tree memory utilization -0.15 [-0.22, -0.08] 1 Logs
quality_gate_idle memory utilization -0.23 [-0.28, -0.17] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.02 [-1.90, -0.14] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.22 [-1.28, -1.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@aureleoules aureleoules force-pushed the aurele.oules/enable-ecs-by-default branch from f45a456 to 41baad8 Compare February 4, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/container-app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants