Retry mechanism for transient errors #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
Changes
is_transient_error
function insidefetcher.py
;[408, 502, 503, 504]
since they're the most common ones, but let me know if I should add/remove any;fetch_url
to retry fetching the url when it encounters a transient error untilretries
reaches 0;fetch_url
function and in thecrawl
method;max_retry_attempts
option toCrawlSettings
;Ps.: The wait times for each consecutive retry attempt are just
1, 2 ,3, ...
seconds. Let me know if that's ok.