-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WDL conformance tests to CI #4530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise looks great! Thanks for adding these.
src/toil/test/wdl/wdltoil_test.py
Outdated
@@ -1,3 +1,4 @@ | |||
import hashlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added by accident?
CI runs on 3.9 which is likely why it is failing
f2962df
to
63a1fbf
Compare
Looks like CI is failing in the spot autoscaling tests; probably the spot price is too high for them or something. I am going to merge this anyway since it has nothing to do with them. |
This resolves #4508. I also updated MiniWDL from 1.9.1 to 1.10.0 as the latest version fixes an issue with expression placeholders that lets two more conformance tests to run. I also marked them as slow as on my machine, each took about 2 minutes to run.
Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist