IA-1552 fix ggplot #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qi77Qi
commented
Dec 27, 2019
| # the next few `sed` lines are workaround for a ggplot bug. See https://github.com/yhat/ggpy/issues/662 | ||
| && sed -i 's/pandas.tslib.Timestamp/pandas.Timestamp/g' /usr/local/lib/python3.7/dist-packages/ggplot/stats/smoothers.py \ | ||
| && sed -i 's/pd.tslib.Timestamp/pd.Timestamp/g' /usr/local/lib/python3.7/dist-packages/ggplot/stats/smoothers.py \ | ||
| && sed -i 's/pd.tslib.Timestamp/pd.Timestamp/g' /usr/local/lib/python3.7/dist-packages/ggplot/utils.py \ |
There was a problem hiding this comment.
these are the fixes for ggplot
There was a problem hiding this comment.
Are those the strictest patterns to match? Like would 's/^pandas.tslib.Timestamp$/^pandas.Timestamp$/g' or something stricter be better?
There was a problem hiding this comment.
I think anywhere pandas.tslib.Timestamp is called will need to be replaced
| && pip3 install google-cloud-datastore==1.10.0 \ | ||
| && pip3 install google-cloud-resource-manager==0.30.0 \ | ||
| && pip3 install google-cloud-storage==1.23.0 \ | ||
| && pip3 install --ignore-installed firecloud==0.16.25 \ |
There was a problem hiding this comment.
upgrade google-cloud-xxx to latest
| && pip3 install bokeh==1.0.0 \ | ||
| && pip3 install pyfasta==0.5.2 \ | ||
| && pip3 install markdown==2.4.1 \ | ||
| && pip3 install pdoc==0.3.2 \ | ||
| && pip3 install pdoc3==0.7.2 \ |
There was a problem hiding this comment.
pdoc doesn't support python 3...pdoc 3 does
| @@ -73,7 +77,7 @@ RUN pip3 -V \ | |||
| && pip3 install intel-openmp==2018.0.0 \ | |||
| && pip3 install mkl==2018.0.3 \ | |||
| && pip3 install readline==6.2 \ | |||
| && pip3 install setuptools==36.4.0 \ | |||
| && pip3 install setuptools==42.0.2 \ | |||
There was a problem hiding this comment.
six and setuptools are upgraded due to some google-cloud-xxx lib requires higher version
kyuksel
approved these changes
Jan 2, 2020
rtitle
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/IA-1552
tested in DataBiosphere/leonardo#1189