-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-182] Convert remaining runtime operations to new Sam permissions model #4820
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4820 +/- ##
===========================================
- Coverage 74.63% 74.62% -0.01%
===========================================
Files 165 166 +1
Lines 14850 14692 -158
Branches 1187 1135 -52
===========================================
- Hits 11083 10964 -119
+ Misses 3767 3728 -39
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, love seeing all that old permission cruft get deleted. Did some manual testing as well and everything seems to function as normal!
Jira ticket: https://broadworkbench.atlassian.net/browse/CORE-182
Summary of changes
What
createRuntime
requiresgoogle-project/launch-notebook-cluster
for a v1 runtime andworkspace/compute
for a v2 runtimedeleteRuntime
requiresnotebook-cluster/delete
getRuntime
requiresnotebook-cluster/status
stopRuntime
andstartRuntime
both requirenotebook-cluster/stop_start
updateRuntime
requiresnotebook-cluster/modify
notebook-cluster/connect
Why
Testing these changes
What to test
Who tested and where
jenkins retest
orjenkins multi-test
.