Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN-347] Bump up helm scala sdk and GKE k8s versions to latest (1.30) #4724

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

LizBaldo
Copy link
Collaborator

@LizBaldo LizBaldo commented Jul 24, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/AN-347

Summary of changes

What

  • Uses the latest Helm Scala SDK version that supports Kubernetes 1.30 for GKE (bumping up Kubernetes for AKS will require PRs in the Landing Zone Service and TCL)

Why

  • There are some really nice features to Kubernetes 1.30 that IA would like to test. @Qi77Qi tagging you in there because this should not, but might impact the deployment of AOU GKE apps

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@LizBaldo LizBaldo requested review from Qi77Qi and lucymcnatt July 24, 2024 14:16
Copy link
Collaborator

@lucymcnatt lucymcnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well

@LizBaldo
Copy link
Collaborator Author

Let's put this on hold until Galaxy has had the chance to test with k8s 1.30

@LizBaldo LizBaldo closed this Oct 7, 2024
@LizBaldo LizBaldo reopened this Jan 22, 2025
@LizBaldo LizBaldo requested a review from a team as a code owner January 22, 2025 15:16
@LizBaldo LizBaldo changed the title [IA-5026] Bump up helm scala sdk and GKE k8s versions to latest (1.30) [AN-347] Bump up helm scala sdk and GKE k8s versions to latest (1.30) Jan 22, 2025
@LizBaldo
Copy link
Collaborator Author

Reopening now that Galaxy is ready on 1.30

@LizBaldo
Copy link
Collaborator Author

Note that I will test this PR on my BEE to make sure that the current Galaxy chart is still working. This is currently not covered by integration tests.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (d986578) to head (2a30320).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4724   +/-   ##
========================================
  Coverage    74.77%   74.77%           
========================================
  Files          166      166           
  Lines        14800    14800           
  Branches      1112     1112           
========================================
  Hits         11067    11067           
  Misses        3733     3733           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d986578...2a30320. Read the comment docs.

@LizBaldo
Copy link
Collaborator Author

The initial integration test failure was due to a permission propagation fluke, and I was able to successfully test creating and deleting a Galaxy instance on my BEE so I think we are good to go :)

@LizBaldo LizBaldo merged commit 2bf4e66 into develop Jan 22, 2025
23 checks passed
@LizBaldo LizBaldo deleted the IA-5026-update-helm-and-k8s branch January 22, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants