Fix some memory leaks with multi-period live streams #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each new period introduces new tracks; they should be completely wiped out of existence once the period is gone from mpd, but it seems some of the dash.js code never ever lets go of them. As of now, each new period introduces many new functions and contexts; many are callbacks into EventBus which reveals some of the worst offenders. And then there are just plain old forgotten cleanups.
Most of the leaks plugged here could be observed by simply looking at JS heap behaviour when browsing http://reference.dashif.org/dash.js/nightly/samples/multiperiod/live.html .