Fix bug in Annex I functional test. Also increase timeout for Karma t…

…ests to 120 seconds
Dash-Industry-Forum · Jan 22, 2025 · f4fc204 · f4fc204
1 parent 674660b
commit f4fc204
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/test/functional/config/karma.functional.conf.cjs b/test/functional/config/karma.functional.conf.cjs
@@ -129,8 +129,8 @@ module.exports = function (config) {
         autoWatch: false,
 
         captureTimeout: 600000,
-        browserNoActivityTimeout: 90000,
-        browserDisconnectTimeout: 90000,
+        browserNoActivityTimeout: 120000,
+        browserDisconnectTimeout: 120000,
         browserDisconnectTolerance: 2,
 
         // start these browsers

diff --git a/test/functional/config/test-configurations/streams/smoke.json b/test/functional/config/test-configurations/streams/smoke.json
@@ -4,7 +4,6 @@
       "all"
     ],
     "excluded": [
-      "vendor/google-ad-manager-emsg"
     ]
   },
   "testvectors": [

diff --git a/test/functional/test/feature-support/annex-i.js b/test/functional/test/feature-support/annex-i.js
@@ -17,15 +17,17 @@ Utils.getTestvectorsForTestcase(TESTCASE).forEach((item) => {
     describe(`${TESTCASE} - ${item.name} - ${mpd}`, () => {
         let playerAdapter;
 
-        before(() => {
+        before(function () {
             if (!item.testdata || !item.testdata.annexI || !item.testdata.annexI.mediaTypes || item.testdata.annexI.mediaTypes.length === 0 || !item.testdata.annexI.expectedQueryString) {
                 this.skip();
             }
             playerAdapter = initializeDashJsAdapter(item, mpd);
         })
 
         after(() => {
-            playerAdapter.destroy();
+            if (playerAdapter) {
+                playerAdapter.destroy();
+            }
         })
 
         it(`Checking playing state`, async () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,6 @@ @@
           "all"
         ],
         "excluded": [
-          "vendor/google-ad-manager-emsg"
         ]
       },
       "testvectors": [
@@ Expand Down @@