Fixes for Windows build failures, and stack overwrite - see #39 and #41 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 21, 2017 15:28
#39 This should all be "transparent" changes. The code has been refactored to remove the dependency on g++ support for non-standard C++ features. * Visual Studio project does not compile with latest (2017) version. > Created .sln and .vcxproj for Visual Studio 2017 following previous naming convention. * In PostprocessData.cpp: for (int j = i; list[j].offset < (offset + segmentSizes[index]); j++) { ... } errprint("[...]",index, list[j].offset); Does not obey C++ standard rules - the scope of the name(s) declared extends to the end of the for statement. > Initialised 'j' prior to the loop. * In ValidateAtoms.cpp: char vsdi_name[strlen(vsdi.name)]; and saio_offset ... Using non-standard C++ (dynamic array length) > vsdi.name is a fixed length, so introduced a #define value. > Allocated 'saio_offset' using new. * In ValidateMP4.h: true and false are #defined. C++ Standard Library forbids macroizing keywords > Commented out the #define of true and false in ValidateMP4.h
andyburras
changed the title
merge latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for stack overwrite - see #41
Fixes for Windows build failures - see
#39
This should all be "transparent" changes. The code has been refactored to remove the dependency on g++ support for non-standard C++ features.
Visual Studio project does not compile with latest (2017) version.
Created .sln and .vcxproj for Visual Studio 2017 following previous naming convention.
In PostprocessData.cpp:
Does not obey C++ standard rules - the scope of the name(s) declared extends to the end of the for statement.
Change: Initialised 'j' prior to the loop.
Using non-standard C++ dynamic array length.
Change: vsdi.name is a fixed length, so introduced a #define value.
Change: Allocated 'saio_offset' using new.
C++ Standard Library forbids macroizing keywords
Change: Commented out the #define of true and false in ValidateMP4.h