better bitset completion #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laytan
commented
Nov 28, 2023
| @@ -790,114 +844,112 @@ get_implicit_completion :: proc( | |||
|
|
|||
| //infer bitset and enums based on the identifier comp_lit, i.e. a := My_Struct { my_ident = . } | |||
| if position_context.comp_lit != nil { | |||
| if position_context.parent_comp_lit.type == nil { | |||
There was a problem hiding this comment.
This whole hunk/part of the diff is just turning this early return if into a regular if (in order to get to the part where call expressions are completed later). All this is just an indentation change.
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more completion support for bitsets.
.it shows all possibilities in the bitset and when completion is confirmed removes the expression, leaving the.Variant. eg:variable.comes up with completionsvariable.Foo,variable.Bar, and confirming will remove thevariable, leaving.Fooa : My_Bitset = { .* }will show the bitset variants after typing the.hello({ . })shows the variants after typing the.For that last point I had to remove an early return which would return if there was a comp literal in the context. This royally screwed the diff though because I had to indent the whole block by one (because of surrounding it with an if). Nothing in that hunk has changed though, just turned the early return into a normal if statement.