Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #485

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update deps #485

wants to merge 4 commits into from

Conversation

w568w
Copy link
Member

@w568w w568w commented Jan 12, 2025

This PR:

  • bumps Android NDK, Gradle, Kotlin to their latest version;
  • bumps flutter_secure_storage to the beta version, so we can get rid of the workaround;
  • re-enables the Kotlin compiler's validation of the JVM target version during Kotlin compilation against the target version set by the Java compiler. Previously, we were ignoring this compilation error. It might be better to enable it and explicitly override the JVM target setting for subprojects in build.gradle;
  • removes tray_manager dependency.

BREAKING CHANGES: Please note that this change will set the minimum and target Java version to 23. As a result, developers will need to install JDK >= 23 to compile the project.

@w568w w568w requested review from HydrogenC and ivanfei-1 January 12, 2025 07:20
Copy link
Collaborator

@HydrogenC HydrogenC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on windows

@w568w
Copy link
Member Author

w568w commented Jan 15, 2025

As the commit reveals, this PR primarily modifies dependencies related to the Android build process.

Therefore, I believe it's necessary to wait for a maintainer who focuses on Android to confirm it compiles on his side before merging.

@w568w w568w added this to the 1.4.7 milestone Jan 15, 2025
@w568w w568w added the help wanted Extra attention is needed label Jan 15, 2025
@HydrogenC
Copy link
Collaborator

HydrogenC commented Jan 15, 2025

As the commit reveals, this PR primarily modifies dependencies related to the Android build process.

Therefore, I believe it's necessary to wait for a maintainer who focuses on Android to confirm it compiles on his side before merging.

Then I believe @kooWZ should be tagged for reviewing this. But I suppose he is struggling with OS(H) lately (so am I though). 😆

@w568w w568w requested a review from kooWZ January 15, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants