Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete sprintf calls #46

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Remove obsolete sprintf calls #46

merged 2 commits into from
Jun 25, 2024

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz commented Jun 24, 2024 •
edited
Loading

Remove obsolete sprintf calls.

@illwieckz illwieckz added the enhancement New feature or request label Jun 24, 2024
@illwieckz illwieckz force-pushed the illwieckz/snprintf branch from 888cfc3 to a610ffa Compare June 24, 2024 08:30
@illwieckz
Copy link
Member Author

The first commit is needed by:

@illwieckz illwieckz mentioned this pull request Jun 24, 2024
Merged
@illwieckz
Copy link
Member Author

illwieckz commented Jun 24, 2024 •
edited
Loading

The appveyor build fails because it is enabled for testing #47 but #47 is not merged yet (so, no .appveyor.yml file yet):

So it's a false positive to be ignored.

Edit: Appveyor now works.

@illwieckz illwieckz force-pushed the illwieckz/snprintf branch 2 times, most recently from 8d33da6 to 05e7c83 Compare June 25, 2024 07:44
@illwieckz illwieckz force-pushed the illwieckz/snprintf branch 2 times, most recently from 1929cc7 to 5920eab Compare June 25, 2024 09:49
@illwieckz illwieckz changed the title remove sprintf calls Remove sprintf calls Jun 25, 2024
@illwieckz illwieckz changed the title Remove sprintf calls Remove obsolete sprintf calls Jun 25, 2024
@slipher
Copy link
Member

slipher commented Jun 25, 2024

LGTM

@illwieckz illwieckz merged commit 7fb66cc into master Jun 25, 2024
3 checks passed
@illwieckz illwieckz deleted the illwieckz/snprintf branch June 25, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slipher slipher slipher left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illwieckz @slipher