Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPDATED: Adding capability to deconvolve using channel-by-channel templates #69

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

UPDATED: Adding capability to deconvolve using channel-by-channel templates #69

wants to merge 8 commits into from

Commits on Nov 7, 2024

  1. Reapply "Adding capability to deconvolve using channel-by-channel tem… 

    …plates"

This reverts commit 7eb23d6.
    @absolution1
    absolution1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0ad78a9 View commit details
    Browse the repository at this point in the history

  2. Reverting number of samples in the default deconvolution configuratio… 

    …n. Changing only the part for PDHD.
    @vpec0 @absolution1
    vpec0 authored and absolution1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    76efc85 View commit details
    Browse the repository at this point in the history

  3. Allow deconvolution to be configured with single SPE template for all… 

    … channels. Default channe = -1. Add default configuration table for FD.
    @vpec0 @absolution1
    vpec0 authored and absolution1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    35fc9e6 View commit details
    Browse the repository at this point in the history

  4. Making the config backwards compatible, i.e. dune_deconvolution table… 

    … will create the same configuration as before the upgrade of the module. Added configuration table for ProtoDUNE MC.
    @vpec0 @absolution1
    vpec0 authored and absolution1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    83292cb View commit details
    Browse the repository at this point in the history

  5. Renaming configurables setting the deconvolution SPE templates to mor… 

    …e explanatory names. Moving PDHD MC template mapping to dune_opdet_channels.fcl.
    @vpec0 @absolution1
    vpec0 authored and absolution1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    98700ee View commit details
    Browse the repository at this point in the history

  6. Fixed incorrectly assigned input label for deconvolution of MC.

    @vpec0 @absolution1
    vpec0 authored and absolution1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f53a516 View commit details
    Browse the repository at this point in the history

  7. Minor fix of a method naming.

    @vpec0 @absolution1
    vpec0 authored and absolution1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    15581d3 View commit details
    Browse the repository at this point in the history

  8. Fixed omissions in name changes of some configurables.

    @vpec0
    vpec0 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    72e0166 View commit details
    Browse the repository at this point in the history