-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build tms with updated geometry for PDR #33
base: master
Are you sure you want to change the base?
Conversation
…ed. Set to false to get stereo design
Allows for the generation of two different types of geometries: pure stereo and full hybrid (every third layer an horizontal layer). To switch between them change in line 409 the variable to True for hybrid and False for stereo |
Running small tests of 10 files of 1e15 pot each using ProcessND.py Ideally, we'd make some pictures of the geometry to verify everything is adjusted the way we want. We've had geometry issues before, like where it was rotated 90 degrees. I've asked about plotting geometry efficiently on slack It also sounds like we need to verify whether the reconstruction parameters may need adjustments. These test files could be used to validate that |
Here are some jobs that worked. Only ran genie and g4 stages. Any failures were due to issues copying flux files Running tmsreco over 50 files from the output above. This version has a fix to the bar sanity check and I verfied it runs over at least one stereo output file above. But it seems to fail on most hybrid files, see below. It's tagged The hybrid file errors are very sparse. It just says,
Note that "not in TMS??" messages may or may not be related. There are additional "not in TMS??" messages that don't crash. The message comes from TMS_Kalman. If there's no simple fix, we should make an issue to track this in dune-tms The program doesn't crash at the same location if I turn off the kalman filter using the config file. But it still crashes with a seg fault:
|
I tried and failed to implement that. The next best solution I could come up with was the 3D browser thing at https://dune.github.io/dunendggd/ It will always have the latest build geometry, so you can inspect the PR build there. Though it only builds the "default geometries" at the moment. So when you did not change those, you have to load your own geometry files from your PC into it. Which is no problem at all, just click on the three dots next to the file selector. |
Thanks! I couldn't find the loading buttons. I had to adjust the center bar until the three dots became visible |
Let me know when this is actually ready for review. So far I assume that this is a WIP. Should maybe be marked as such. |
…mments to position numbers
With the PDR for TMS coming up, the design of TMS has been adapted. The number of thin and thick steel layers has been changed, with a third option (double layers) being added as well. In addition the horizontal modules will be studied and need to be implemented as well.
Also the number of number of scintillator bars per module changed from 48 to 32 with 6 instead of 4 modules now