Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re implement sand options history and update #16

Closed

Conversation

GianfrancoIngratta
Copy link
Contributor

Added a bullet on the Changelog.md.

@ast0815
Copy link
Member

ast0815 commented Jul 21, 2023

You just created a PR that includes all the commits we already merged in the last PR. Could you rebase the changelog change on top of the current master branch? The new PR should only include the commit that you actually want to change. And it should probably be renamed as well...

@ast0815
Copy link
Member

ast0815 commented Jul 21, 2023

When you rebase the branch, you might have to force push in order to update the remote version.

@ast0815
Copy link
Member

ast0815 commented Jul 26, 2023

Handled in #17.

@ast0815 ast0815 closed this Jul 26, 2023
@ast0815 ast0815 deleted the re_implement_SAND_options_history_and_update branch July 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants