Skip to content

Commit

Permalink
Bump gegede version. (#25)
Browse files Browse the repository at this point in the history
* Bump gegede versionb.

* Remove gegede fix from actions.

Fixes #24
  • Loading branch information
ast0815 authored Mar 26, 2024
1 parent 3213bfb commit 820b2f9
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 15 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Setup gegede
run: pip install git+https://github.com/brettviren/gegede.git@86ca28190516a23203cd883aafb0548a61664ceb
- name: Setup
run: pip install .
- name: Build default gdml files
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup gegede
run: pip install git+https://github.com/brettviren/gegede.git@86ca28190516a23203cd883aafb0548a61664ceb
- name: Setup
run: pip install .
- name: Build defaul gdml
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Geometry releases will be tagged as `Descriptive_tag_v_X.Y.Z`.

## [Unreleased]

### Changed

- Bump gegede to version 0.8.0

### Removed

- Removed old gdml files from repo.
Expand Down
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,6 @@ dunendggd is based on [GeGeDe](https://github.com/brettviren/gegede) and started

# Setup

## Prerequisites

This package requires `gegede`.
Unfortunately, the latest version of `gegede` which supports Python 3 [is _not_ on PyPI](https://github.com/brettviren/gegede/issues/18) yet.
This means we have to install a suitable version directly from GitHub:

```bash
pip install git+https://github.com/brettviren/gegede.git@86ca28190516a23203cd883aafb0548a61664ceb
```

## Installing dunendggd

This package can be installed as user using `pip`:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
package_dir = {},
packages = ['duneggd', 'duneggd.Det', 'duneggd.SubDetector', 'duneggd.Component', 'duneggd.Active', 'duneggd.LocalTools', 'duneggd.Booleans', 'duneggd.Hall', 'duneggd.ArgonCube'],
install_requires = [
"gegede >= 0.6.1", # In reality we need the '0.7' tag, but its setup.py still reports itself as 0.6.1
"gegede >= 0.8.0",
"pint >= 0.5.1", # for units
"lxml >= 3.3.5", # for GDML export],
],
Expand Down

0 comments on commit 820b2f9

Please sign in to comment.