Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile page #3

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Profile page #3

merged 5 commits into from
Mar 24, 2022

Conversation

GuilhermeRCost
Copy link
Contributor

@GuilhermeRCost GuilhermeRCost commented Mar 23, 2022 •
edited
Loading

AlineLermen
AlineLermen requested changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@AlineLermen AlineLermen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the images should be on the foler Assets
For example the path should be /src/Assets/image.png

@AlineLermen
Copy link
Contributor

Also, please add the following to the PR description:

Resolve Issue https://github.com/DS-FeudoVerdePantano/GameReview-Docs/issues/11

This links this PR to its respective issue in the GameReview-Docs repository

AlineLermen
AlineLermen approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@AlineLermen AlineLermen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuilhermeRCost GuilhermeRCost merged commit 60996ae into develop Mar 24, 2022
@LucasBergholz LucasBergholz deleted the ProfilePage branch March 30, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlineLermen AlineLermen AlineLermen approved these changes

Assignees

@samuelalvess samuelalvess

@LucasBergholz LucasBergholz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuilhermeRCost @AlineLermen @samuelalvess @LucasBergholz