This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Address Chrome lag issues #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was referenced Nov 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue(s) #2111
😎 PREVIEW
This PR addresses the lag issues that we were seeing on Chrome browsers. If you look in the console, you should no longer see a warning message telling us that the main thread was delayed and encouraging us to use passive event listeners on the
wheelandscrollevents.As an extension of this, I submitted a PR to the main stickyfill repo. Usage of the stickyfill npm module will be doubly delayed as we need webmodules/stickyfill, a repo that has been modified to support the module
requiremethod, to add any updates to wilddeer/stickyfill to the npm modulestickyfillChanges proposed in this pull request:
{ passive: true }on event listeners.requirereferences./cc @meiqimichelle