Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executors/go: allow new compiler syscalls #1195

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Dec 21, 2024

need these syscalls to upgrade go 1.22.5 to go 1.23.4

go took 6 seconds according to these logs

Sat, 21 Dec 2024 21:30:42 GMT    Testing GASARM: Unable to natively debug
Sat, 21 Dec 2024 21:30:48 GMT    Testing GO:     Using /usr/bin/go
Sat, 21 Dec 2024 21:30:48 GMT      go: 1.23.4

@dmoj-build
Copy link
Collaborator

Can one of the admins verify this patch?

@quantum5
Copy link
Member

ok to test

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.26%. Comparing base (7701313) to head (a1761b0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
dmoj/executors/GO.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1195       +/-   ##
===========================================
- Coverage   63.00%   49.26%   -13.75%     
===========================================
  Files         143      143               
  Lines        5442     5442               
===========================================
- Hits         3429     2681      -748     
- Misses       2013     2761      +748     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quantum5 quantum5 merged commit d7a2735 into DMOJ:master Dec 21, 2024
10 checks passed
@int-y1 int-y1 deleted the fix-go branch December 21, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants