Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions CI #1008

Merged
merged 19 commits into from
Jun 18, 2024
Merged

Update Github Actions CI #1008

merged 19 commits into from
Jun 18, 2024

Conversation

joergbrech
Copy link
Contributor

@joergbrech joergbrech commented May 14, 2024

Fixes #1006

  • Updated action versions to update Node.js

  • The updated codecov action now needs a token to upload coverage reports. This has been added. Also I needed to add some arguments to the codecov action so that both unit and integration tests are picked up.

  • Needed to downgrade macos version, because the latest runner updated to the new arm architecture which is not supported by our build system yet (another To-Do for us)

  • Needed to update boost and gradle to build on macos. The update of gradle auto-changed some of the files in the bindings/java directory.

  • The update of boost had a dependency conflict with qt, so I needed to update qt

       The following packages are incompatible
         ├─ libboost 1.82.0**  is installable and it requires
         │  └─ icu >=73.1,<74.0a0 , which can be installed;
         └─ qt 5.9.7**  is not installable because it requires
            └─ icu >=58.2,<59.0a0 , which conflicts with any installable versions previously reported.

    In addition, I now got a weird ninja error on all platforms: ninja: error: build.ninja:6801: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you. So I updated ninja

  • The newer Qt Version distributed with Anaconda was apparently build with gcc>9, which resulted in a GLIBC and GLIBCXX conflict on the Ubuntu 20.04 runner that only has g++ 9.3 installed. To save myself the trouble, I just removed ubuntu-20.04 from the build matrix. As of now, ubuntu-latest and ubuntu-22.04 are the same, but I suppose github will soon switch ubuntu-latest to ubuntu-24.04 and then we will be testing two different linux configs again.

@joergbrech joergbrech force-pushed the 1006-fix-ci branch 6 times, most recently from f6e2dc9 to 5cb93fb Compare May 16, 2024 10:24
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.81%. Comparing base (42935bb) to head (b0d726f).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   68.97%   69.81%   +0.84%     
==========================================
  Files         299      299              
  Lines       26499    24166    -2333     
==========================================
- Hits        18277    16871    -1406     
+ Misses       8222     7295     -927     
Flag Coverage Δ
unittests 69.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/COptionList.h 100.00% <ø> (+1.58%) ⬆️
...rc/structural_elements/CCPACSFuselageWallSegment.h 33.33% <ø> (ø)

... and 234 files with indirect coverage changes

@joergbrech joergbrech force-pushed the 1006-fix-ci branch 5 times, most recently from 7aa9af1 to 56e1ebf Compare June 6, 2024 12:03
note that this requires an update of qt to avoid a depencency conflict by conda,
which in turn requires an update of ninja
@joergbrech joergbrech force-pushed the 1006-fix-ci branch 2 times, most recently from 7957089 to cc4acbc Compare June 7, 2024 06:58
@joergbrech joergbrech force-pushed the 1006-fix-ci branch 2 times, most recently from be478a2 to 5f3156d Compare June 7, 2024 08:01
@joergbrech joergbrech force-pushed the 1006-fix-ci branch 3 times, most recently from 087f9b2 to 8f035df Compare June 7, 2024 08:39
@joergbrech joergbrech force-pushed the 1006-fix-ci branch 2 times, most recently from 24c7ef2 to 1d8aaeb Compare June 10, 2024 09:25
@joergbrech joergbrech marked this pull request as ready for review June 17, 2024 12:21
@joergbrech joergbrech requested review from AntonReiswich and svengoldberg and removed request for AntonReiswich June 17, 2024 12:21
@joergbrech
Copy link
Contributor Author

@MarAlder: Because you were interested: With this PR, tigl still uses the boost version distributed in the thirdparty subdir, but:

  • The distributed boost version has been updated
  • You can change this behavior by setting the CMAKE variable TIGL_USE_INTERNAL_BOOST to false and installing boost some other way, e.g. using conda.

@MarAlder
Copy link
Collaborator

Nice! I just like it when a repo works with as few third-party software copies as possible. Having both options is of course a nice solution as well. Building boost in particular is always a bit tricky...

Copy link
Contributor

@svengoldberg svengoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as I can tell

.github/actions/test-win/action.yml Outdated Show resolved Hide resolved
@joergbrech joergbrech merged commit dfa7ca1 into master Jun 18, 2024
17 checks passed
@joergbrech joergbrech deleted the 1006-fix-ci branch June 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI once again...
3 participants