-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Actions CI #1008
Update Github Actions CI #1008
Conversation
f6e2dc9
to
5cb93fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 68.97% 69.81% +0.84%
==========================================
Files 299 299
Lines 26499 24166 -2333
==========================================
- Hits 18277 16871 -1406
+ Misses 8222 7295 -927
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7aa9af1
to
56e1ebf
Compare
note that this requires an update of qt to avoid a depencency conflict by conda, which in turn requires an update of ninja
7957089
to
cc4acbc
Compare
be478a2
to
5f3156d
Compare
087f9b2
to
8f035df
Compare
24c7ef2
to
1d8aaeb
Compare
@MarAlder: Because you were interested: With this PR, tigl still uses the boost version distributed in the thirdparty subdir, but:
|
Nice! I just like it when a repo works with as few third-party software copies as possible. Having both options is of course a nice solution as well. Building boost in particular is always a bit tricky... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as far as I can tell
Fixes #1006
Updated action versions to update Node.js
The updated codecov action now needs a token to upload coverage reports. This has been added. Also I needed to add some arguments to the codecov action so that both unit and integration tests are picked up.
Needed to downgrade macos version, because the latest runner updated to the new arm architecture which is not supported by our build system yet (another To-Do for us)
Needed to update boost and gradle to build on macos. The update of gradle auto-changed some of the files in the bindings/java directory.
The update of boost had a dependency conflict with qt, so I needed to update qt
In addition, I now got a weird ninja error on all platforms:
ninja: error: build.ninja:6801: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
. So I updated ninjaThe newer Qt Version distributed with Anaconda was apparently build with gcc>9, which resulted in a GLIBC and GLIBCXX conflict on the Ubuntu 20.04 runner that only has g++ 9.3 installed. To save myself the trouble, I just removed ubuntu-20.04 from the build matrix. As of now, ubuntu-latest and ubuntu-22.04 are the same, but I suppose github will soon switch ubuntu-latest to ubuntu-24.04 and then we will be testing two different linux configs again.