-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make check_env assertions in regards to observation_space more actionable #1400
Make check_env assertions in regards to observation_space more actionable #1400
Conversation
All working now, except for the following
Any suggestions for fixing that? I don't have much experience with type checking in python... |
Issue resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks =)
(I refactored the tests and extended the checks to numpy arrays)
Description
Provide more actionable assertions when checking the observation_space, as requested in #1399
In particular, add dedicated
AssertionError
for:obs
andobservation_space
obs
andobservation_space
obs
andobservation_space
obs
andobservation_space
Misc:
make lint
warning about checking availability of moduleREADME
section about running testsMotivation and Context
The current mode of failure is not telling much about why it fails.
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line