Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow, skip mypy for 3.8 #466

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Update CI workflow, skip mypy for 3.8 #466

merged 3 commits into from
Jul 26, 2024

Conversation

qgallouedec
Copy link
Collaborator

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin
Copy link
Member

araffin commented Jul 23, 2024

oh, I think I know what happened, this is this PR: DLR-RM/stable-baselines3#1963

we need to see if there is an easy to have backward compat.

@araffin
Copy link
Member

araffin commented Jul 26, 2024

Now tests are passing with the new fix =)

@araffin araffin merged commit 9846160 into master Jul 26, 2024
16 checks passed
@araffin araffin deleted the update_ci branch July 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants