Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set highway-env version to 1.5 and setuptools to v65.5 #353

Merged
merged 6 commits into from
Feb 6, 2023

Conversation

qgallouedec
Copy link
Collaborator

@qgallouedec qgallouedec commented Feb 6, 2023

Description

Highway-env

highway-env v1.6.0 requires gym>=0.25. I realised that in #330, but I made a mistake and set the version to 1.6 and not to 1.5. For some reason, the CI passed, even though the error was properly detected: See https://github.com/DLR-RM/rl-baselines3-zoo/actions/runs/3765113949/jobs/6400251954#step:4:645

Setptools

See #307 (comment), the checks fail because setuptools v67 is not satisfied with the way gym is packaged. This requirement should be dropped for the later version of gym.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@qgallouedec qgallouedec changed the title Downgrade highway-env to 1.5.0 Set highway-env version to 1.5 and setuptools to v65.5 Feb 6, 2023
@qgallouedec qgallouedec marked this pull request as ready for review February 6, 2023 10:49
@araffin araffin merged commit 1c93af8 into master Feb 6, 2023
@araffin araffin deleted the qgallouedec-patch-1 branch February 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants