Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PointListReader for reading single-element (Point1D case) per line #1708

Merged
merged 7 commits into from
Nov 10, 2023

Conversation

Seangongx
Copy link
Contributor

@Seangongx Seangongx commented Nov 2, 2023

PR Description

  • Fixed the failure when give the extreme input case by single-element(Like typedef DGtal::PointVector<1, DGtal::int32_t> Point1D) using getPolygonsFromInputStream() function.
  • Changed the sample data and added new test.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Seangongx just a typo and could you please add an entry on the changelog file that probably forget to add ?

tests/io/readers/testPointListReader.cpp Outdated Show resolved Hide resolved
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me thanks @Seangongx

@kerautret kerautret merged commit bc9abf4 into DGtal-team:master Nov 10, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants