-
Notifications
You must be signed in to change notification settings - Fork 23
Update Manuscript generation to work with sibmei #119
Conversation
…on and writing failed
Facilitates renaming libmei.plg (e.g. for different MEI versions)
Previously, this was only the case for self-closing elements
Apply changes that were made in the libmei shipping with sibmei
dbcfe34
to
19c0cf2
Compare
as far as I remember, the Not sure why the |
Ah, I see -- the |
Can you explain how removing prefixes might cause collisions? The reason to remove them was actually to avoid collisions with other versions of libmei. Sibelius binds the prefix to the file name of the plugin. If we rename the Without a prefix, only methods from the same |
I realize that I accidentally applied the "Update dead weblink" commit twice (and reverted it once) while combining the separate pull requests. I can rebase to fix this if necessary. |
Wouldn't you want to change this line, then, if you've renamed the plugin? https://github.com/DDMAL/libmei/blob/master/tools/langs/manuscript.py#L883 |
Also, you should add yourself to the AUTHORS. |
As I understand it, the libmei generation should be usable for any version or customization. I would therefore not change the default output name. When used, it can be renamed to anything that is appropriate. |
I don't understand. So you're wanting to have two different libmei plugins installed (one for v3, one for v4), and you want to generate the libmei code for v4, but you don't want to change the plugin name? |
I can use the libmei generator to create a libmei for basically any MEI schema, be it v3, v4 or any customization I like, right? Therefore the default name ef2ca39 makes sure that libmei will work no matter what its file name is. |
To avoid the need of conflict resolution with merging commits one by one, this pull request supersedes #111, #112, #116 and #117.
This includes changes that were made to the libmei shipping with sibmei. For example, the
RemoveChild()
method was added with 24f5b43 in 2015, but was never added to the libmei generator.Goal is that we can generate libmei for sibmei without having to manually merge changes every time.