Allow edits to chants with no existing full text; fix browse source dropdown #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow DDMAL#1712 and conform pagination styling of the browse chants templates to other filterable table templates.
Allow edits to chants that did not have an initial full text to be saved even if no full text is added. Add check for uniqueness of folio-c_sequence to the chant edit page. This requires inclusion of the chant source in the chant edit form: the form, view, and test are edited to add the source to the form. Refs: DDMAL#1696.
Moves validity checks on the Chant Create view to the Chant Create Form. Refs: DDMAL#1713.
dchiller
force-pushed
the
i1696-allow-save-for-no-full-text
branch
from
c5c964d to
d69a155
Compare
lucasmarchd01
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Source.short_headingin dropdown on the Browse Chants view.Adjust requirement for a chant to have a non-empty
manuscript_full_text_std_spellingfield. This PR maintains the requirement for this field to be filled out on chant creation. On chant edit, a chant can be saved with an emptymanuscript_full_text_std_spellingfield iff that field was already empty. This allows necessary edits to other fields (e.g., changing a genre, feast, or service designation) without necessarily having to locate the full chant text.Closes #1696. Closes #1715.
Refs #1713: Moves folio-sequence uniqueness check to the
ChantCreateFormrather than theChantCreateView. Also adds this check to theChantEditForm(previously this was not checked at all on chant edits).