Maintain compatibility in export APIs #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of the institution model and the change from office to service introduced changes in external APIs (the JSON CID export, the JSON melody export, and the cached concordances command). This commit rolls back those changes to maintain compatibility. The modifications may be reintroduced at a later date if notice is given to external users (in particular, Cantus Index). Also simplifies the logic and adjusts the typing of functions related to the JSON melody export and the AJAX melody list views to address DDMAL#1638. Makes relevant changes to associated tests. Fixes additional type errors in views/api.py. Refs DDMAL#1641.
lucasmarchd01
approved these changes
Oct 4, 2024
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In updating our source and institution identification scheme and in changing "office" to "service" on chants, we made a number of changes to keys in APIs used by external applications. These changes are reversed here so as not to cause issues with those services.
We can discuss whether making changes to the external APIs should proceed -- I do want to avoid breaking something on Cantus Index without giving time for relevant changes to occur there.
Also fixes a variety of typing issues in
views/api.pyand does some refactoring.Closes #1641. Closes #1638.