Display additional chant fields on Chant Detail page when they exist #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmarchd01
approved these changes
Jul 24, 2024
Ah! I think because I hadn't run @ahankinson's migrate_records command yet when I took the screenshot. |
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the chant detail page to include additional fields added for the Benedicamus Domino project (#1473). These include:
Screenshots for these cases below.
Additionally, in profiling the chant detail page, I discovered our view was making a duplicate query. I've refactored the view code to eliminate this duplicate.
Chant detail page for chant with polyphony and function fields filled
Chant detail page for chant in Benedicamus Domino project
Closes #1495. Closes #1496.