Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/mypage: 마이페이지 및 인증게시판 API 연동 #83

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

lxxmnmn
Copy link
Collaborator

@lxxmnmn lxxmnmn commented Jan 17, 2023

💡 개요

related issue: #28

📑 작업 사항

  • 인증 게시판, 마이페이지 내 리뷰목록, 인증목록 API 연동
  • UserInfo 컴포넌트 관련 style 수정

🔎 etc

  • 결과가 없는 페이지 디자인 추가되면 반영 예정
  • 준모님 메인페이지 작업 후에 좋아요한 카페 목록 API 연동 진행
  • 백엔드에 레벨명 변경 요청 필요 (초보 ➡️ 탈출노비)

@lxxmnmn lxxmnmn self-assigned this Jan 17, 2023
@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for exitnow ready!

Name Link
🔨 Latest commit 426a517
🔍 Latest deploy log https://app.netlify.com/sites/exitnow/deploys/63c8aee4e6c819000964a849
😎 Deploy Preview https://deploy-preview-83--exitnow.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Jan 17, 2023



Test summary

9 0 0 0


Run details

Project DDD8-EXIT
Status Passed
Commit e57a1e8 ℹ️
Started Jan 19, 2023 2:47 AM
Ended Jan 19, 2023 2:48 AM
Duration 00:44 💡
OS Linux Ubuntu -
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

data: JsonWebTokenType;
};

export type LoginResponseType = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response 타입 상속 받으면 되지 않을까요.!
ResponseDataType 중복 타입 선언같습니다..! 없어도 될거같네요😀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거는 다음 pr 때 반영하겠습니다..!

Copy link
Member

@choipureum choipureum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 붙였네요! 특별히 리뷰 할 내용은 없습니다. 로컬 테스트는 못해봤는데요, 겹치는 부분이 많아 페이지 테스트들 진행 후 붙이면될거같습니다

@lxxmnmn lxxmnmn merged commit ce61df3 into main Jan 19, 2023
@lxxmnmn lxxmnmn deleted the feat/mypage branch January 19, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants