Mara 23 친구 냉장고 화면 구현 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choipureum
reviewed
Jan 24, 2024
There was a problem hiding this comment.
해당 부분은 아이콘이 추가될 수록 관리가 점차 힘들어 질 것 같은데요..!
svgr를 사용해서 아이콘 컴포넌트화를 통해 관리하던지 따로 배럴파일을 둬서 아이콘을 에셋으로 관리하던지 선택이 필요해 보입니다.🙀
choipureum
reviewed
Jan 24, 2024
| </svg> | ||
| ); | ||
|
|
||
| export const ArrowRightGray: React.FC<React.SVGProps<SVGSVGElement>> = ( |
There was a problem hiding this comment.
색상과 방향 정도는 커스텀해도 좋을 것 같습니다..! 컴포넌트화의 이점을 살려서 Arrow 컴포넌트를 두고 방향과 스트로크정도는 커스텀화 해서 확장성 있게 가져가는게 좋아보입니다..!👀
choipureum
reviewed
Jan 24, 2024
| 냉장고 추가 | ||
| </button> | ||
| {!isMyFridgeList && ( | ||
| <button className="flex justify-center items-center h-[64px] border-2 rounded-[12px] text-gray3"> |
There was a problem hiding this comment.
공통으로 사용하는 버튼들은 atom에 미리 빼놔도 좋을 것 같네유..!🙇♂️
choipureum
approved these changes
Jan 24, 2024
|
머지를 해버려서,, 마크업수정하면서 시맨틱 추가하겠습니당 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
이슈번호: Mara-23
작업내용