-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Mara-22 into main #6
Conversation
PR 감사드립니다.
번거로우시겠지만 고려부탁드립니다~!🌸 |
src/components/atoms/GeenButton.tsx
Outdated
} | ||
|
||
const GreenButton: React.FC<GreenButtonProps> = ({ text, className }) => { | ||
const GreenButton: React.FC<GreenButtonProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버튼 컴포넌트는 범용적으로 사용 될 가능성이 높아서,
Button 컴포넌트로 생성하고 props로 컬러를 받아서 사용해도 좋을 것 같아요!
title: string; | ||
children: React.ReactNode; | ||
} | ||
const IngredientAddItem: React.FC<IngredientAddItemProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
children을 props로 받아서 감싸는 컴포넌트의 경우에는 가독성을 위해서 container을 붙여서 네이밍을 하시는 것도 추천드려요~!😀
src/components/atoms/GreenLink.tsx
Outdated
@@ -9,12 +10,13 @@ interface GreenLinkProps { | |||
|
|||
const GreenLink: React.FC<GreenLinkProps> = ({ text, className }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 버튼 컴포넌트는 저희 디자인에서 많이 사용 될 것 같은 버튼이라서 link로 한정하기 보다는 공통으로 사용 될 수 있고 알아보기 쉽게 Button 컴포넌트에 onClick props로 넘겨줘도 자주 사용 될 것 같아요 🥺🌈
요구사항
이슈번호: MARA-22
작업내용