feat: 친구 페이지 친구 삭제, 내 초대코드 조회, 친구 추가 API 연동 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
conflict 낫네유 |
choipureum
reviewed
Feb 22, 2024
| </button> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
이런 형태도 가능할 것 같네요..!🙇♂️
Suggested change
| const CheckBox: React.FC<{ active: boolean; onClick: () => void }> = ({ | |
| active = false, | |
| onClick, | |
| }) => { | |
| const commonStyle = 'flex justify-center items-center w-20 h-20 rounded-full'; | |
| const buttonClassName = `${commonStyle} ${active ? 'bg-primary2' : 'border border-gray5'}`; | |
| return ( | |
| <button onClick={onClick} className={buttonClassName}> | |
| <CheckIcon stroke={active ? '기본값 혹은 undefined' : '#9299AA'} /> | |
| </button> | |
| ); | |
| }; | |
| export default CheckBox; |
There was a problem hiding this comment.
분기 파편화 이슈가 생길까봐 고민 했었는데 공유 주신 코드가 훨씬 간결해보이네요 👍🏻
반영해두었습니다
choipureum
reviewed
Feb 22, 2024
| const { showToast } = useToast(); | ||
| const addFriendship = useAddFriendship({ | ||
| onSuccess: () => { | ||
| showToast('친구 추가가 완료되었습니다.', 'success'); |
There was a problem hiding this comment.
constants들로 매직스트링들은 관리하는게 좋아보입니당
choipureum
reviewed
Feb 22, 2024
| } | ||
| }; | ||
|
|
||
| const { data: myInviteCode } = useBaseQuery<{ inviteCode: string }>( |
There was a problem hiding this comment.
피드백 감사합니다😊 수정해서 반영해두었습니다 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
이슈번호: MARA-79
작업내용
테스트 결과 또는 방법