Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARA-65 에러바운더리, fallback #17

Merged
merged 21 commits into from
Feb 17, 2024
Merged

MARA-65 에러바운더리, fallback #17

merged 21 commits into from
Feb 17, 2024

Conversation

a-honey
Copy link
Member

@a-honey a-honey commented Feb 14, 2024

요구사항

이슈번호: Mara-65

작업내용

  • 로그인 api 쿼리로 변경
  • tanstack query v5 useQuery onError deprecated로 전역 에러바운더리 설정
  • Error Fallback, Suspense Fallback 추가(src/templates)
  • api 요청 baseURL 환경변수에 추가

테스트 결과 또는 방법

Error Fallback

/fridge에서 api 요청 보내면 500에러로 Error Fallback 확인 가능합니당
image

Suspense Fallback

일단 500 에러여서 useGetIngredientList api 요청을 'https://jsonplaceholder.typicode.com/todos'로 보내서 확인했습니다
Animation

@a-honey a-honey self-assigned this Feb 14, 2024
@a-honey a-honey added the duplicate This issue or pull request already exists label Feb 14, 2024
Copy link
Member

@choipureum choipureum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!👏

Copy link
Member

@hyeseon-han hyeseon-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 👍🏻

@a-honey a-honey merged commit 0c73d9b into main Feb 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants