New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MARA-44 나눔 상세, 나눔 글 작성 화면 구현 #12

Merged

hyeseon-han merged 22 commits into main from MARA-44

Feb 5, 2024

Member

hyeseon-han commented Feb 4, 2024 •

edited

Loading

요구사항

이슈번호: Mara-44 Mara-45

작업내용

나눔 상세 화면 구현
나눔 글 작성 화면 구현

테스트 결과 또는 방법

hyeseon-han requested review from choipureum and a-honey

February 4, 2024 14:06

hyeseon-han changed the title ~~Mara-44 나눔 상세, 나눔 글 작성 화면 구현~~ MARA-44 나눔 상세, 나눔 글 작성 화면 구현

choipureum assigned hyeseon-han

choipureum reviewed

View reviewed changes

src/assets/icons/CircleClose.tsx Outdated Show resolved Hide resolved

choipureum reviewed

View reviewed changes

src/components/organisms/InputLabelContainer.tsx Outdated Show resolved Hide resolved

choipureum reviewed

View reviewed changes

src/components/organisms/ShareDetailAuthorBottomWrapper.tsx Outdated Show resolved Hide resolved

choipureum reviewed

View reviewed changes

src/pages/add-share/index.tsx Show resolved Hide resolved

choipureum reviewed

View reviewed changes

src/pages/add-share/index.tsx Show resolved Hide resolved

choipureum reviewed

View reviewed changes

src/pages/add-share/index.tsx Show resolved Hide resolved

choipureum reviewed

View reviewed changes

src/pages/share/[id].tsx Outdated Show resolved Hide resolved

choipureum approved these changes

View reviewed changes

Member

choipureum left a comment •

edited

Loading

고생하셨습니다!🥰
[IMO] 전체적으로 관심사나 덩어리이 분리가 좀더 되면 더 좋을 것 같습니다!☺️

a-honey approved these changes

View reviewed changes

Member Author

hyeseon-han commented Feb 5, 2024 •

edited

Loading

@choipureum 급하게 진행하느라 커밋 양도 많고 놓친 부분들도 많았는데 꼼꼼하게 체크 해주셔서 감사합니다 🙇‍♀️ 👍🏻

hyeseon-han added 16 commits

February 5, 2024 23:37


          chore: Header component barrel 파일에 추가

ea109e9


          chore: ClockIcon, DateIcon 추가

2b3bc88


          fix: SearchIcon 수정

1d327f9


          style: 나눔 탭 모달 style 수정

20bb6b0


          style: scroll bar 숨기도록 수정

dab5bf8


          style: bottomNavigation component style 수정

a37448d


          feat:VerticalLabelValue, ShareInfoRowItem component 구현

b91e8ec


          feat: 나눔 상세 화면 구현

65ed73b


          chore: Icon svg error 수정

bc29574


          style: 나눔조회, 나눔 상세 Modal style 수정

92b309e


          fix: eslint 수정

7dc404b


          style: global.css input style 설정 제거

718bacd


          chore: CameraIcon, CircleIcon component 추가

c0cc873


          feat: 나눔 글쓰기 화면 구현 MARA-45

3c99476


          chore: CircleClose -> CircleCloseIcon component name 수정

6ce1773


          chore: ShareDetailAuthorBottomWrapper button -> Button component로 대체

a60b6e0

hyeseon-han added 6 commits

February 5, 2024 23:37


          chore: textarea maxLength 설정

4130f45


          chore: input date type 설정

7bbcd3b


          style: ShareDetail thumbnail image style 수정

cab7f69


          style: SharePage style 수정

9edd58d


          style: scroll bar 안보이도록 전역으로 설정

1fbfd34


          fix: build error 수정

ba6ba7d

hyeseon-han force-pushed the MARA-44 branch from 2ec4837 to ba6ba7d Compare

February 5, 2024 14:37

hyeseon-han merged commit 15088ce into main

1 check passed

hyeseon-han deleted the MARA-44 branch

February 5, 2024 14:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet