Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing 'errno' definition. #106

Closed

Conversation

Naum-PDFTron
Copy link

@Naum-PDFTron Naum-PDFTron commented Jul 25, 2024

Description

Compiling on Linux Docker image with gcc4.8 reports missing 'errno'. Included 'cerrno'.

Changelog entry

N/A

Copy link
Member

@michaelonken michaelonken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does including also work for you if you put it below the osconfig.h include, e.g. before the windows.h include #ifdef?

We want osconfig.h to be the first include in any DCMTK file.

@Naum-PDFTron
Copy link
Author

Naum-PDFTron commented Jul 25, 2024

It doesn't matter where it is put. I thought system includes go first. Here what we are getting:
Build-#15
I can modify it and put it where you decide.

@michaelonken
Copy link
Member

I realized that your branch is still using an old DCMTK commit from March.

Meanwhile the related file has already been fixed regarding errno by starting like this:

#include "dcmtk/config/osconfig.h"

#include "dcmtk/ofstd/ofchrenc.h"
#include "dcmtk/ofstd/ofstd.h"
#include "dcmtk/ofstd/ofdiag.h"
#include "dcmtk/ofstd/ofconsol.h"
#include <cerrno>

Thanks for the report anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants