Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2382: ccm-lb: add backoff to avoid performance issues w/locking #2383

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

#2382: ccm-lb: add backoff to avoid performance issues w/locking #2383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e85dd8c
#2375: scripts: add lb_iterations to JSON data file schema validator
lifflander Dec 6, 2024
70aa8b0
#2382: ccm-lb: add backoff to avoid performance issues w/locking
lifflander Dec 18, 2024
71f0ea5
#2382: ccm-lb: add max iter time and cycle lock count
lifflander Dec 19, 2024
6cc5fd9
#2382: ccm-lb: fix bug
lifflander Dec 19, 2024
8e14f8d
#2382: ccm-lb: fix iter time so it's not additive
lifflander Dec 19, 2024
77190a3
#2382: ccm-lb: implement incremental update for cluster summaries
lifflander Dec 23, 2024
56338f7
#2382: ccm-lb: fix some compile-time issues
lifflander Dec 23, 2024
1889b34
#2382: ccm-lb: stop adding cluster when load is zero (empty cluster)
lifflander Dec 23, 2024
dc55d2c
#2382: ccm-lb: another optimization
lifflander Dec 23, 2024
900f9aa
#2382: ccm-lb: reduce sleep to 100us
lifflander Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 59 additions & 1 deletion scripts/LBDatafile_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,65 @@ def validate_ids(field):
'bytes': float
}
],
Optional('user_defined'): dict
Optional('user_defined'): dict,
Optional('lb_iterations'): [
{
'id': int,
'tasks': [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. I wonder if it is possible to avoid repetition by having task defined separately 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this might work:

Task = {
    'entity': And({
        Optional('collection_id'): int,
        'home': int,
        Optional('id'): int,
        Optional('seq_id'): int,
        Optional('index'): [int],
        'type': str,
        'migratable': bool,
        Optional('objgroup_id'): int
    }, validate_ids),
    'node': int,
    'resource': str,
    Optional('subphases'): [
        {
            'id': int,
            'time': float,
        }
    ],
    'time': float,
    Optional('user_defined'): dict,
    Optional('attributes'): dict
}
                        'tasks': [
                            Task,
                        ],

{
'entity': And({
Optional('collection_id'): int,
'home': int,
Optional('id'): int,
Optional('seq_id'): int,
Optional('index'): [int],
'type': str,
'migratable': bool,
Optional('objgroup_id'): int
}, validate_ids),
'node': int,
'resource': str,
Optional('subphases'): [
{
'id': int,
'time': float,
}
],
'time': float,
Optional('user_defined'): dict,
Optional('attributes'): dict
},
],
Optional('communications'): [
{
'type': str,
'to': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'messages': int,
'from': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'bytes': float
}
],
Optional('user_defined'): dict
}
]
},
]
}
Expand Down
Loading
Loading