#2382: ccm-lb: add backoff to avoid performance issues w/locking #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifflander
force-pushed
the
2382-fix-performance-issues-with-ccm-lb
branch
from
2ea8a29 to
ccb3bb1
Compare
|
This might need a more complete treatment with a increasing backoff, but for now this code is running well. |
lifflander
force-pushed
the
2382-fix-performance-issues-with-ccm-lb
branch
from
023b907 to
1889b34
Compare
lifflander
force-pushed
the
2382-fix-performance-issues-with-ccm-lb
branch
from
e7bd01a to
900f9aa
Compare
cz4rs
reviewed
Jan 7, 2025
| Optional('lb_iterations'): [ | ||
| { | ||
| 'id': int, | ||
| 'tasks': [ |
There was a problem hiding this comment.
Looks correct. I wonder if it is possible to avoid repetition by having task defined separately 🤔
There was a problem hiding this comment.
Something like this might work:
Task = {
'entity': And({
Optional('collection_id'): int,
'home': int,
Optional('id'): int,
Optional('seq_id'): int,
Optional('index'): [int],
'type': str,
'migratable': bool,
Optional('objgroup_id'): int
}, validate_ids),
'node': int,
'resource': str,
Optional('subphases'): [
{
'id': int,
'time': float,
}
],
'time': float,
Optional('user_defined'): dict,
Optional('attributes'): dict
} 'tasks': [
Task,
],
cz4rs
reviewed
Jan 7, 2025
| auto info = makeClusterSummary(id); | ||
| cur_clusters_.emplace(id, std::move(info)); | ||
|
|
||
| //computeClusterSummary(); |
cz4rs
reviewed
Jan 7, 2025
| ); | ||
| } | ||
|
|
||
| auto iter = try_locks_.begin(); | ||
| auto lock = *iter; | ||
| try_locks_.erase(iter); | ||
|
|
||
| if (lock.forced_release) { | ||
| std::this_thread::sleep_for(std::chrono::microseconds(100)); |
There was a problem hiding this comment.
Magic number: put a comment why 100 is good.
cz4rs
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2382