Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#363: Bump version to 1.5.0 ahead of release #364

Merged
merged 6 commits into from
Sep 19, 2024
Merged

#363: Bump version to 1.5.0 ahead of release #364

merged 6 commits into from
Sep 19, 2024

Conversation

cwschilly
Copy link
Contributor

@cwschilly cwschilly commented Sep 17, 2024 •
edited
Loading

Fixes #363

This PR:

  • bumps version number to 1.5.0 everywhere
  • updates checkpoint --> magistrate in the license
  • fixes a problem in the CI where docker-compose command was not found

@cwschilly cwschilly linked an issue Sep 17, 2024 that may be closed by this pull request
Bump version to 1.5.0 ahead of release #363
Closed
@nlslatt
Copy link
Contributor

nlslatt commented Sep 17, 2024

CI is broken. Is this new?

@cwschilly
Copy link
Contributor Author

cwschilly commented Sep 17, 2024 •
edited
Loading

CI is broken. Is this new?

No idea. Could it be related to the mismatched licenses? (e.g. this pipeline)

@cwschilly cwschilly self-assigned this Sep 18, 2024
@cwschilly
Copy link
Contributor Author

cwschilly commented Sep 18, 2024 •
edited
Loading

I'm not super familiar with magistrate's CI, but this fix seems to work.

It is strange though that the discussion I linked to suggests that we should have run into this problem in April, and it hasn't shown up until now (CI was passing as recently as July).

@cwschilly cwschilly requested a review from nlslatt September 18, 2024 14:03
@cwschilly
Copy link
Contributor Author

@nlslatt @lifflander

magistrate pulls in vt on one of the CI pipelines. Right now, it targets develop--should we change this to 1.5.0 (once vt has released)?

@lifflander lifflander merged commit 3d60dd6 into develop Sep 19, 2024
19 checks passed
@cwschilly cwschilly deleted the 363-bump-version-to-150-ahead-of-release branch September 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@nlslatt nlslatt Awaiting requested review from nlslatt

Assignees

@cwschilly cwschilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump version to 1.5.0 ahead of release
3 participants
@cwschilly @nlslatt @lifflander