Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meag D onboarding msg #1174

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Conversation

meagdoh
Copy link
Contributor

@meagdoh meagdoh commented Aug 8, 2017

I rule and have completed some work on Case Manager that's ready for review!

(brief, plain english overview of your changes here)

This pull request makes the following changes:

  • Adds a new Welcome Message

(If there are changes to the views, please include a screenshot so we know what to look for!)

It relates to the following issue #s:

Copy link
Member

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -24,7 +24,8 @@ def welcome_messages
"Have no fear, Team CM is here!",
"The work that you do is essential and helps so many people!",
"Thank you for fighting the good fight!",
'You rock!'
'You rock!',
"You are invaluable - keep it up!!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@colinxfleming colinxfleming merged commit fc11ef2 into DARIAEngineering:master Aug 8, 2017
@codecov-io
Copy link

Codecov Report

Merging #1174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1174   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          52       52           
  Lines        1153     1153           
=======================================
  Hits         1099     1099           
  Misses         54       54
Impacted Files Coverage Δ
app/helpers/welcome_message_helper.rb 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e2ef2...d210288. Read the comment docs.

@colinxfleming
Copy link
Member

welcome aboard @meagdoh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants